Homec4science

Use new Differential bucketing logic on default (non-dashboard) homepage

Authored by epriestley <git@epriestley.com> on May 19 2016, 22:28.

Description

Use new Differential bucketing logic on default (non-dashboard) homepage

Summary:
Ref T10939. If you haven't installed a dashboard, we show an "Active Revisions" panel on the homepage by default. I waited a bit to update this, but the new buckets don't seem to have caused any major problems so far.

Update this to use the new logic. I'm just showing "must review" + "should review", which is similar to the old beahvior.

Also replace the notification count with this same number. This is a little different from the old behavior, but simpler, and I think we should probably move toward getting rid of these counts completely.

Test Plan:

  • Viewed homepage as logged-in user, saw my revisions (including revisions I have authority over only because of project membership).
  • Saw consistent notification count.
  • Grepped for removed method.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15950

Details

Committed
epriestley <git@epriestley.com>May 20 2016, 00:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0fad3847271c: Fix minor section formatting mishap in SSH key email
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7ae33d14ec7b: Use new Differential bucketing logic on default (non-dashboard) homepage (authored by epriestley <git@epriestley.com>).May 20 2016, 00:20