Homec4science

Enforce upload size limits and transport exceptions with appropriate response…

Authored by epriestley <git@epriestley.com> on May 7 2012, 15:17.

Description

Enforce upload size limits and transport exceptions with appropriate response encoding

Summary:

  • When a user uploads an oversized file, throw an exception.
  • When an uncaught exception occurs during a Conduit request, return a Conduit response.
  • When an uncaught exception occurs during a non-workflow Ajax request, return an Ajax response.

Test Plan:

  • Uploaded overlarge files.
  • Hit an exception page with ?ajax=1 and ?conduit=1

Reviewers: btrahan, vrana, jungejason

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T875, T788

Differential Revision: https://secure.phabricator.com/D2385

Details

Committed
epriestley <git@epriestley.com>May 7 2012, 15:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb80ea9e0e85a: Revert cd63d9b2ce26 / D2403, see diff. This broke inline comments by making…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7b5f47b17d6e: Enforce upload size limits and transport exceptions with appropriate response… (authored by epriestley <git@epriestley.com>).May 7 2012, 15:17