Homec4science

Throw CommandException instead of Exception after `git fetch` failure in…

Authored by epriestley <git@epriestley.com> on Dec 12 2015, 01:48.

Description

Throw CommandException instead of Exception after git fetch failure in repository updates

Summary: Fixes T9966. In this unusual, difficult-to-reach case, we throw Exception (which has no censoring) instead of CommandException (which has censoring). Throw CommandException instead.

Test Plan:

  • Hacked up a bunch of stuff in order to hit this: disabled origin validation, origin correction, and pointed repository at a bad domain.
  • Verified message is now censored correctly.

{F1022217}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9966

Differential Revision: https://secure.phabricator.com/D14745

Details

Committed
epriestley <git@epriestley.com>Dec 12 2015, 01:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4ec6990ca767: Implement a rough initial version of ApplicationSearch-driven Conduit read…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7b997359466f: Throw CommandException instead of Exception after `git fetch` failure in… (authored by epriestley <git@epriestley.com>).Dec 12 2015, 01:53