Homec4science

Improve atomizing of PHP `@return` annotation

Authored by Joshua Spence <josh@joshuaspence.com> on Jan 22 2015, 21:18.

Description

Improve atomizing of PHP @return annotation

Summary: Fixes T6890. This doesn't feel like a perfect solution, but I can't think of any cases in which this will produce the wrong result either.

Test Plan: Ran ./bin/diviner generate and checked the generated documentation for PhabricatorCommonPasswords::loadWordlist(). The return type was corrected shown as map<string, bool>.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6890

Differential Revision: https://secure.phabricator.com/D11469

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jan 22 2015, 21:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH25ee2d4508d8: Rename `DifferentialHunk` subclasses for consistency
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH7bd2994c2e21: Improve atomizing of PHP `@return` annotation (authored by Joshua Spence <josh@joshuaspence.com>).Jan 22 2015, 21:18