Homec4science

Simplify selection of inline comments from RevisionView

Authored by epriestley <git@epriestley.com> on Jun 24 2013, 20:01.

Description

Simplify selection of inline comments from RevisionView

Summary: Ref T2222. Currently, we load inline comments by commentID here, but we always pass every commentID associated with the revision. Instead, just load non-draft comments by revision ID. This simplifies querying a little bit and is likely faster anyway (draft comments are currently loaded separately).

Test Plan: Looked at some revisions and verified inlines showed up correctly and in the right places.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D6270

Details

Committed
epriestley <git@epriestley.com>Jun 24 2013, 20:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3124838d6567: Undo D6266 (DifferentialComment PHID migration)
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7c2f6f8361c2: Simplify selection of inline comments from RevisionView (authored by epriestley <git@epriestley.com>).Jun 24 2013, 20:01