Homec4science

Declare common Lisk properties

Authored by vrana <jakubv@fb.com> on Oct 3 2012, 20:14.

Description

Declare common Lisk properties

Summary:
Calling ->setPHID() or other common Lisk setters creates an implicit public property $phid.
I don't like implicit properties and I see them as errors.
Its public visibility also makes me nervous and is vulnerable to bypassing any setters we may create.

Test Plan: Loaded homepage, checked log.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3600

Details

Committed
vrana <jakubv@fb.com>Oct 3 2012, 20:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH92aaffd0c572: Fix inconsistence in declared VS used property
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH7c39c4ca7d35: Declare common Lisk properties (authored by vrana <jakubv@fb.com>).Oct 3 2012, 20:53