Homec4science

Fix D2490 (make macro handler correctly bail if there are no macros)

Authored by Bob Trahan <bob.trahan@gmail.com> on May 20 2012, 01:19.

Description

Fix D2490 (make macro handler correctly bail if there are no macros)

Summary: D2490 was not my finest hour and I incorrectly thought it was a null value from error. In reality this error is impossible and its just a valid empty array so instead use the empty predicate to bail.

Test Plan: with our logic combined, this be tested

Reviewers: vrana, epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2503

Details

Committed
Bob Trahan <bob.trahan@gmail.com>May 20 2012, 01:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH912e414013fa: Update Conduit Maniphest CRUD API(s) to not accept crud
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH7c42ade61714: Fix D2490 (make macro handler correctly bail if there are no macros) (authored by Bob Trahan <bob.trahan@gmail.com>).May 20 2012, 01:19