Homec4science

Conpherence - make empty comment submission behave like other apps

Authored by Bob Trahan <bob.trahan@gmail.com> on Jan 30 2013, 01:53.

Description

Conpherence - make empty comment submission behave like other apps

Summary: now we get a "you can't submit no text" error. Also puts the participant status updating inside the editor.

Test Plan: made empty comments and got the right error dialogue. made legit comments and they went through. made a new conpherence - work. edited title + picture on old conpherence - worked. tried to submit non-updates to title and image - correct error.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2419

Differential Revision: https://secure.phabricator.com/D4734

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jan 30 2013, 01:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3ee9921f2d2e: improve image hinting for 220 preview
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH7c5f0250a667: Conpherence - make empty comment submission behave like other apps (authored by Bob Trahan <bob.trahan@gmail.com>).Jan 30 2013, 01:53