Homec4science

Implement DestructibleInterface for Owners Packages

Authored by epriestley <git@epriestley.com> on Dec 10 2015, 14:14.

Description

Implement DestructibleInterface for Owners Packages

Summary:
Fixes T9945. This is straightforward.

The two sub-object types are very lightweight so I just deleted them directly instead of loading + delete()'ing (or implementing DestructibleInterface on them, which would require they have PHIDs).

Also improve a US English localization.

Test Plan:

  • Used bin/remove destroy PHID-... --trace to destroy a package.
  • Verified it was gone.
  • Inspected the SQL in the log for general reasonableness.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9945

Differential Revision: https://secure.phabricator.com/D14729

Details

Committed
epriestley <git@epriestley.com>Dec 10 2015, 16:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPH90c4880aaa7b: Add PhabricatorOwnersArchiveController
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7c98cd85fe6d: Implement DestructibleInterface for Owners Packages (authored by epriestley <git@epriestley.com>).Dec 10 2015, 16:04