Diffusion Phabricator 7cfc87bbe65e

Improve rendering of many GitHub event strings
7cfc87bbe65e
Actions

Authored by epriestley <git@epriestley.com> on Mar 24 2016, 13:55.

Description

Improve rendering of many GitHub event strings

Summary: Ref T10538. This makes us render better human-readable descriptions of more GitHub event types.

Test Plan: Ran unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10538

Differential Revision: https://secure.phabricator.com/D15516

Details

Committed

epriestley <git@epriestley.com>

Mar 24 2016, 16:57

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHb1937962663d: Provide "Reproduction Steps" docs and separate "Version" doc

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7cfc87bbe65e: Improve rendering of many GitHub event strings (authored by epriestley <git@epriestley.com>).Mar 24 2016, 16:57

Changes (23)

				Path
	M			src/applications/nuance/github/NuanceGitHubRawEvent.php
	M			src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php
	M			src/applications/nuance/github/__tests__/issueevents/assigned.txt
	M			src/applications/nuance/github/__tests__/issueevents/closed.txt
	M			src/applications/nuance/github/__tests__/issueevents/demilestoned.txt
	M			src/applications/nuance/github/__tests__/issueevents/labeled.txt
	M			src/applications/nuance/github/__tests__/issueevents/locked.txt
	M			src/applications/nuance/github/__tests__/issueevents/milestoned.txt
	M			src/applications/nuance/github/__tests__/issueevents/renamed.txt
	M			src/applications/nuance/github/__tests__/issueevents/reopened.txt
	M			src/applications/nuance/github/__tests__/issueevents/unassigned.txt
	M			src/applications/nuance/github/__tests__/issueevents/unlabeled.txt
	M			src/applications/nuance/github/__tests__/issueevents/unlocked.txt
	P			src/applications/nuance/github/__tests__/repositoryevents/CreateEvent.tag.txt Copied from src/applications/nuance/github/__tests__/repositoryevents/WatchEvent.started.txt
	M			src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.pull.txt
	M			src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.txt
	M			src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.closed.txt
	M			src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.opened.txt
	M			src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.reopened.txt
	M			src/applications/nuance/github/__tests__/repositoryevents/PullRequestEvent.opened.txt
	M			src/applications/nuance/github/__tests__/repositoryevents/PushEvent.txt
	P			src/applications/nuance/github/__tests__/repositoryevents/WatchEvent.started.txt Copied to src/applications/nuance/github/__tests__/repositoryevents/CreateEvent.tag.txt
	M			src/applications/nuance/item/NuanceGitHubEventItemType.php