Homec4science

Improve error handling for Aphlict.

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 8 2014, 00:16.

Description

Improve error handling for Aphlict.

Summary: Currently, any error thrown when instantiating an AphlictMaster will be assumed to be due to the master already existing. This is a bit overzealous because the documentation specifically states than an ArgumentError will be throw if "the LocalConnection instance is already connected".

Test Plan: Inspected the log message.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9422

Details

Committed
epriestley <git@epriestley.com>Jun 8 2014, 00:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc5ee3a4522fe: Serve aphlict.swf through Celerity
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7d255aedba43: Improve error handling for Aphlict. (authored by Joshua Spence <josh@joshuaspence.com>).Jun 8 2014, 00:16