Homec4science

Make everything 1000x or 1000000x slower

Authored by epriestley <git@epriestley.com> on May 23 2015, 14:36.

Description

Make everything 1000x or 1000000x slower

Summary:
In the great pht() conversion, some strings like "123,456" are now being printed as numbers with "%d". These come out as "123" instead of "123,456".

Use "%s" and "PhutilNumber" to present numbers with comma groupings.

Test Plan:

  • Viewed DarkConsole.
  • Viewed conduit logs.
  • Viewed daemon logs.
  • Grepped for %d ms and %d us.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12979

Details

Committed
epriestley <git@epriestley.com>May 23 2015, 14:36
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6481884d26d3: Translating day view into javascript, actually.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7d757483a0db: Make everything 1000x or 1000000x slower (authored by epriestley <git@epriestley.com>).May 23 2015, 14:36