Homec4science

Fix excessively harsh validation of certain complex configuration

Authored by epriestley <git@epriestley.com> on Jan 11 2016, 23:15.

Description

Fix excessively harsh validation of certain complex configuration

Summary:
See IRC. We're supposed to repair configuration, but if custom validators throw a generic Exception or use PhutilTypeSpec to do a check, we may explode way harder than we intend to.

Instead, soften these exceptions into validation exceptions so we repair configuration, raise a setup issue, and continue.

Test Plan: {F1059609}

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14998

Details

Committed
epriestley <git@epriestley.com>Jan 11 2016, 23:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8e1b2f986151: Remove "username@phabricator.mycompany.com" creating a Conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7e0558612b33: Fix excessively harsh validation of certain complex configuration (authored by epriestley <git@epriestley.com>).Jan 11 2016, 23:20