Homec4science

Make various Drydock CLI/Allocator improvements

Authored by epriestley <git@epriestley.com> on Nov 7 2012, 00:30.

Description

Make various Drydock CLI/Allocator improvements

Summary:

  • Remove EC2, RemoteHost, Application, etc., blueprints for now. They're very proof-of-concept and Blueprints are getting API changes I don't want to bother propagating for now. Leave the abstract base class and the LocalHost blueprint. I'll restore the more complicated ones once better foundations are in place.
  • Remove the Allocate controller from the web UI. The original vision here was that you'd manually allocate resources in some cases, but it no longer makes sense to do so as all allocations come from leases now. This simplifies allocations and makes the rule for when we can clean up resources clear-cut (if a resource has no more active leases, it can be cleaned up). Instead, we'll build resources like the localhost and remote hosts lazily, when leases come in for them.
  • Add some configuration to manage the localhost blueprint.
  • Refactor canAllocateResources() into isEnabled() (for config checks) and canAllocateMoreResources() (for quota checks, e.g. too many resources are allocated already).
  • Juggle some signatures to align better with a world where blueprints generally do allocate.
  • Add some more logging and error handling.
  • Fix an issue with log ordering.

Test Plan: Allocated some localhost leases.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2015

Differential Revision: https://secure.phabricator.com/D3902

Details

Committed
epriestley <git@epriestley.com>Nov 7 2012, 00:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0e774dac9342: Make minor improvements to Drydock web interface
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7e0ce0815435: Make various Drydock CLI/Allocator improvements (authored by epriestley <git@epriestley.com>).Nov 7 2012, 00:30