Homec4science

Allow redirecting when not logged in

Authored by Nick Harper <nharper@fb.com> on Sep 5 2012, 23:16.

Description

Allow redirecting when not logged in

Summary:
Without this, the https redirect doesn't work if you're not logged in, because
the login check in willBeginExecution happens before the redirect controller
can redirect. This also has the unpleasant effect of the login page on http
(when it should have redirected to https) not having any css or js.

Test Plan:
With the https redirect enabled, loaded phabricator without being logged in,
and saw that I got redirected to the https login page instead of seeing a
http login page.

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3438

Details

Committed
Nick Harper <nharper@fb.com>Sep 5 2012, 23:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb3d7ed3e8e09: Respect users with duplicate real names in commit parser
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH7e1f5bc9df62: Allow redirecting when not logged in (authored by Nick Harper <nharper@fb.com>).Sep 5 2012, 23:16