Homec4science

Convert "profile" image transforms to the new pathway

Authored by epriestley <git@epriestley.com> on May 13 2015, 00:50.

Description

Convert "profile" image transforms to the new pathway

Summary:
Ref T7707. This ends up being sort of complicated: to support 100x100 images in T4406, we need to scale small images up so they look OK when we scale them back down with background-size in CSS.

The rest of it is mostly straightforward.

Test Plan:

  • Did an OAuth handshake and saw a scaled-up, scaled-down profile picture that looked correct.
  • Used Pholio, edited pholio, embedded pholio.
  • Uploaded a bunch of small/weird/big images and regenerated all their transforms.
  • Uploaded some text files into Pholio.
  • Grepped for removed methods, etc.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7707

Differential Revision: https://secure.phabricator.com/D12818

Details

Committed
epriestley <git@epriestley.com>May 13 2015, 20:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH75f621123301: Convert "preview" image transforms to new pathway
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7e365eb8ae8c: Convert "profile" image transforms to the new pathway (authored by epriestley <git@epriestley.com>).May 13 2015, 20:38