Homec4science

Daemons - handle daemons that can't be killed a bit better

Authored by Bob Trahan <btrahan@phacility.com> on Sep 4 2014, 00:19.

Description

Daemons - handle daemons that can't be killed a bit better

Summary:
Ref T2374. Fixes T5988.

Keep track of what's been killed and not been killed, and surface that maybe you need sudo if things don't get killed with --force

...also basically make this force thing work. I managed to convinced myself stuff was getting killed with --force when it mostly wasn't. Make sure the --force parameter gets pushed as low as it needs to go to have things get killed.

Test Plan:

  • sudo ./bin/phd restart
  • rm -rf /var/tmp/phd/pid/*
  • ./bin/phd stop --> get warning about rogue daemons
  • ./bin/phd stop X --> get warning about no running daemons
  • ./bin/phd stop --force --> get warning about not being able to kill daemons
  • sudo ./bin/phd stop --force --> kill daemons successfully

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T2374, T5988

Differential Revision: https://secure.phabricator.com/D10386

Details

Committed
Bob Trahan <btrahan@phacility.com>Sep 4 2014, 00:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH69d788e4e983: Minor, add a missing space so this command gets marked up as code
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH7ecbc707846f: Daemons - handle daemons that can't be killed a bit better (authored by Bob Trahan <btrahan@phacility.com>).Sep 4 2014, 00:19