Homec4science

Recheck if revision hasn't been already closed in commit parser

Authored by vrana <jakubv@fb.com> on Sep 26 2012, 20:57.

Description

Recheck if revision hasn't been already closed in commit parser

Summary:
If attaching a commit or checking if there are any changes takes nonzero time then the revision may be closed by someone else.

Cleaner solution would be to do it inside a transaction and mark the SELECT as FOR UPDATE but it would be blocking.

Test Plan: Patched $should_close to be true, reparsed an already closed commit.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3555

Details

Committed
vrana <jakubv@fb.com>Sep 27 2012, 06:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf1d4755c6171: Fix unit test updates so a diff update has a predictable unit test status
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH7ed8b6d7fa19: Recheck if revision hasn't been already closed in commit parser (authored by vrana <jakubv@fb.com>).Sep 27 2012, 06:12