Homec4science

Fix two issues with Phriction "recent updates" list

Authored by epriestley <git@epriestley.com> on Jul 10 2013, 01:22.

Description

Fix two issues with Phriction "recent updates" list

Summary:
First, I broke the addIcon() call recently with bad greps.

Second, a user is reporting an issue on GitHub (https://github.com/facebook/phabricator/issues/346) which I can't reproduce but which could reasonably occur for various reasons. Don't depend on being able to find the source/target of a move.

Test Plan: Looked at recent updates in Phriction.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, seungrye

Differential Revision: https://secure.phabricator.com/D6389

Details

Committed
epriestley <git@epriestley.com>Jul 10 2013, 01:22
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1888a84b7eda: Fix an issue with setting "Real Name Attributes" in LDAP auth
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7ef2eac29ff4: Fix two issues with Phriction "recent updates" list (authored by epriestley <git@epriestley.com>).Jul 10 2013, 01:22