Homec4science

Modularize all the mail preferences

Authored by epriestley <git@epriestley.com> on Jun 5 2016, 00:16.

Description

Modularize all the mail preferences

Summary:
Ref T4103. This isn't completely perfect but should let us move forward without also expanding scope into "too much mail".

I split the existing "Mail Preferences" into two panels: a "Mail Delivery" panel for the EditEngine settings, and a "2000000 dropdowns" panel for the two million dropdowns. This one retains the old code more or less unmodified.

Test Plan:

  • Ran unit tests, which cover most of this stuff.
  • Grepped for all removed constants.
  • Ran migrations, inspected database results.
  • Changed settings in both modified panels.
  • This covers a lot of ground, but anything I missed will hopefully be fairly obvious.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16038

Details

Committed
epriestley <git@epriestley.com>Jun 5 2016, 17:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd326b239aeea: Resolve timezone conflicts in a modern transactional way
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7ef6c0a523fc: Modularize all the mail preferences (authored by epriestley <git@epriestley.com>).Jun 5 2016, 17:50