Homec4science

Make more Diffusion controllers/views capability-sensitive

Authored by epriestley <git@epriestley.com> on Sep 27 2013, 19:49.

Description

Make more Diffusion controllers/views capability-sensitive

Summary:
Ref T603. I got most of this earlier, but finish it up.

  • Make a couple of controllers public; pretty much everything in Diffusion has implicit policy checks as a result of building a DiffusionRequest.
  • Add an "Edit" capability to commits.
  • Swap out the comment thing for commits.
  • Disable actions if the user can't take them.

Test Plan: Viewed a bunch of interfaces while logged out, got appropriate results or roadblocks.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7152

Details

Committed
epriestley <git@epriestley.com>Sep 27 2013, 19:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5799e8e2de67: Provide better strings in policy errors and exceptions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7f0d0e4e6cc0: Make more Diffusion controllers/views capability-sensitive (authored by epriestley <git@epriestley.com>).Sep 27 2013, 19:49