Homec4science

Don't load attached files for profile images

Authored by epriestley <git@epriestley.com> on Jun 9 2015, 00:39.

Description

Don't load attached files for profile images

Summary:
Ref T8478. I think the cycle is:

  • Conpherence Thread > Loads handle for participant > loads file for profile image > loads attached files to check visibility > loads conpherence thread > ...

So, specifically, someone attached their profile image to a thread or message somewhere.

This breaks the cycle by stopping the attached-files visibility check from happening, since we don't need it. This seemed like the easiest link in the chain to break.

Ideally, I think the longer-term and more complete fix here is to stop Conpherence from requiring handles in order to load thread handles (and, generally, having a "handles must not load other handles" rule), but that's not trivial and might not be especially practical.

Test Plan: Will test in production.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8478

Differential Revision: https://secure.phabricator.com/D13216

Details

Committed
epriestley <git@epriestley.com>Jun 9 2015, 00:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd6afce7d3097: Stop "join project" from trying to write an inverse edge on Users
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7f5919de1c1c: Don't load attached files for profile images (authored by epriestley <git@epriestley.com>).Jun 9 2015, 00:39