Homec4science

Add missing execution on archived task query

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 18 2015, 14:40.

Description

Add missing execution on archived task query

Summary: Fixes T8599. I'm not sure how to reproduce the original issue, but I'm fairly confident that the issue is that the issue is that execute() is not called on the query object.

Test Plan: Created a Harbormaster build plan with a single "Lease Host" step. Ran ./bin/harbormaster build --plan 1 D1 from the command line and hit the exception as described in T8599. Applied patch and hit a different exception (which I think is just because I don't know how to use #drydock and #harbormaster).

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: hach-que, epriestley, Korvin

Maniphest Tasks: T8599

Differential Revision: https://secure.phabricator.com/D13335

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jun 18 2015, 14:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdad29171fffb: Add more languages to syntax highlighting options
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH7f6508af5a3d: Add missing execution on archived task query (authored by Joshua Spence <josh@joshuaspence.com>).Jun 18 2015, 14:40