Homec4science

Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod

Authored by epriestley <git@epriestley.com> on May 6 2015, 00:44.

Description

Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod

Summary: We were adding "+1" to PHP_INT_MAX, which could cause us to wrap and run git log -n -9223372036854775808 .... Git, unable to give us negative nine trillion zillion results, would then exit without producing results.

Test Plan: Got results out of this method.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12726

Details

Committed
epriestley <git@epriestley.com>May 6 2015, 00:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7e4d5f76c046: Refactor logic for getting next/prev month and day on month and day views…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7f8ee4e32966: Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod (authored by epriestley <git@epriestley.com>).May 6 2015, 00:44