Homec4science

Stop markup cache from hitting cache O(N^2) times

Authored by epriestley <git@epriestley.com> on Feb 26 2014, 22:17.

Description

Stop markup cache from hitting cache O(N^2) times

Summary:
The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan: "Query" tab of services is no longer quite so ridiculous in Differential.

Reviewers: btrahan, dctrwatson

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8352

Details

Committed
epriestley <git@epriestley.com>Feb 26 2014, 22:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7f5b15c6faaf: Made some classes final.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7ff211065555: Stop markup cache from hitting cache O(N^2) times (authored by epriestley <git@epriestley.com>).Feb 26 2014, 22:17