Homec4science

Make directories with spaces in their names work OK in diffusion end to end

Authored by Bob Trahan <bob.trahan@gmail.com> on May 21 2012, 00:29.

Description

Make directories with spaces in their names work OK in diffusion end to end

Summary:
we were parsing the git log output slightly incorrectly and over-exploding on spaces. we also needed to escape the path %20 stuff`.

Not sure if there's something fancy to do given folks should reparse their repos if they are impacted by this issue.

Test Plan:
made a directory with spaces and some dummy revisions. observed diffs wouldn't load and links broken.
with patch, ran scripts/reparse.php for pertinent revisions and diffs loaded and links weren't broken.

Reviewers: floatinglomas, epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Maniphest Tasks: T1252

Differential Revision: https://secure.phabricator.com/D2510

Details

Committed
Bob Trahan <bob.trahan@gmail.com>May 21 2012, 00:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb624dc4e7b87: Increase result set to 100 from 25 for "attach" dialog
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH80f479d94812: Make directories with spaces in their names work OK in diffusion end to end (authored by Bob Trahan <bob.trahan@gmail.com>).May 21 2012, 00:29