Homec4science

Validate menu item fields (links, projects, dashboards, applications, forms…

Authored by epriestley <git@epriestley.com> on Jan 20 2017, 20:03.

Description

Validate menu item fields (links, projects, dashboards, applications, forms, etc)

Summary:
Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan:

  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12128

Differential Revision: https://secure.phabricator.com/D17235

Details

Committed
epriestley <git@epriestley.com>Jan 20 2017, 20:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH98a29f3de90a: Put "View Edit History" above "Remove Comment" in timeline comment action…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8113b7691089: Validate menu item fields (links, projects, dashboards, applications, forms… (authored by epriestley <git@epriestley.com>).Jan 20 2017, 20:58