Homec4science

Diffusion - clean up catching ConduitException

Authored by Bob Trahan <btrahan@phacility.com> on Feb 17 2015, 23:01.

Description

Diffusion - clean up catching ConduitException

Summary: Ref T7123. Turns out that we might throw ConduitClientException now in proxied scenarios. For all but one callsite remove the try / catch bit and don't issue the call for SVN. For the remaining callsite, also don't issue the call for SVN but keep in the exception logic since its renders a pretty error message in the non-proxied case?

Test Plan: played around with diffusion and things looked okay.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7123

Differential Revision: https://secure.phabricator.com/D11789

Details

Committed
Bob Trahan <btrahan@phacility.com>Feb 17 2015, 23:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3fcc3fdedf20: Diffusion - be sure to properly unserialize result from conduit query
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH81d2f2686c4e: Diffusion - clean up catching ConduitException (authored by Bob Trahan <btrahan@phacility.com>).Feb 17 2015, 23:01