Homec4science

Prepare file responses for streaming chunks

Authored by epriestley <git@epriestley.com> on Mar 14 2015, 16:29.

Description

Prepare file responses for streaming chunks

Summary:
Ref T7149. This still buffers the whole file, but is reaaaaal close to not doing that.

Allow Responses to be streamed, and rewrite the range stuff in the FileResponse so it does not rely on having the entire content available.

Test Plan:

  • Artificially slowed down downloads, suspended/resumed them (works in chrome, not so much in Safari/Firefox?)
  • Played sounds in Safari/Chrome.
  • Viewed a bunch of pages and files in every browser.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: joshuaspence, epriestley

Maniphest Tasks: T7149

Differential Revision: https://secure.phabricator.com/D12072

Details

Committed
epriestley <git@epriestley.com>Mar 14 2015, 16:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2aefb438439d: Support a file data iteration interface for large files
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH81d88985a027: Prepare file responses for streaming chunks (authored by epriestley <git@epriestley.com>).Mar 14 2015, 16:29