Homec4science

Hide tooltips on any keypress

Authored by epriestley <git@epriestley.com> on Mar 12 2014, 19:29.

Description

Hide tooltips on any keypress

Summary:
Fixes T4586, where a keystroke like "return" to submit a form could remove DOM nodes rendering a tooltip, leaving the user with a permanent phantom tooltip.

(@spicyj, if you come up with anything better than this feel free to send a followup, but I think this is a reasonable fix.)

A nice side effect of this is that it hides any tooltips obscuring a text input when you start typing.

Test Plan: Hovered over a tooltip, pressed a key, tip vanished.

Reviewers: spicyj, btrahan

Reviewed By: btrahan

Subscribers: aran, spicyj, epriestley

Maniphest Tasks: T4586

Differential Revision: https://secure.phabricator.com/D8497

Details

Committed
epriestley <git@epriestley.com>Mar 12 2014, 19:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPH27485bc64415: Add type=submit to AphrontDialogView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH82aeb59ecf9e: Hide tooltips on any keypress (authored by epriestley <git@epriestley.com>).Mar 12 2014, 19:29