Homec4science

Clean up some EditEngine meta-policies

Authored by epriestley <git@epriestley.com> on Dec 7 2015, 23:55.

Description

Clean up some EditEngine meta-policies

Summary:
Ref T9908. Simplify some of the policies here:

  • If you can edit an application (currently, always "Administrators"), you can view and edit all of its forms.
  • You must be able to edit an application to create new forms.
  • Improve some error messages.
  • Get about halfway through letting users reorder forms in the "Create" menu if they want to sort by something weird since it'll need schema changes and I can do them all in one go here.

Test Plan:

  • Tried to create and edit forms as an unprivileged user.
  • Created and edited forms as an administrator.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9908

Differential Revision: https://secure.phabricator.com/D14700

Details

Committed
epriestley <git@epriestley.com>Dec 8 2015, 00:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPHafacdbd814cc: Use AphrontDialog for New/Move Phame Posts
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH82e67e6bb971: Clean up some EditEngine meta-policies (authored by epriestley <git@epriestley.com>).Dec 8 2015, 00:40