Homec4science

Arrayish fields should always return arrays

Authored by Edward Speyer <edward@fb.com> on Jun 19 2012, 06:07.

Description

Arrayish fields should always return arrays

Summary:
Array-like fields in HerladCommitAdapter should always return things of
type array. If they return array(...) or null, then array_*() functions
sporadically break.

Test Plan:
Ran a PhabricatorRepositoryCommitHeraldWorker for a troublesome commit.
Failed before; fails no more.

Reviewers: epriestley, jungejason

Reviewed By: epriestley

CC: aran, Korvin, vdt

Maniphest Tasks: T1385

Differential Revision: https://secure.phabricator.com/D2793

Details

Committed
Edward Speyer <edward@fb.com>Jun 19 2012, 20:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc53ed032c95e: Link libphutil docs
Branches
Unknown
Tags
Unknown

Event Timeline

Edward Speyer <edward@fb.com> committed rPH83a5f1479d2f: Arrayish fields should always return arrays (authored by Edward Speyer <edward@fb.com>).Jun 19 2012, 20:18