Homec4science

make arc diff link maniphest tasks with revisions

Authored by Bob Trahan <bob.trahan@gmail.com> on Dec 3 2011, 01:20.

Description

make arc diff link maniphest tasks with revisions

Summary:
add "Maniphest Task:" or "Maniphest Tasks:" followed by text that has TX in it.
foreach TX the task will be attached to the revision and the revision will be
attached to the task. parsing is pretty... ummm, robust such that it will pick
up any TX substring and parse that as a Maniphest Task just fine. it errors
out if there is not an actual task for TX and otherwise churns along pretty
nicely.

Also, make sure the PhabricatorObjectHandle loads the task ID as the alternateID
since we need that here and it should be that way anyhoo.

Test Plan:
made a diff and in the commit message added Maniphest Task(s): TX combination.
Tried various combinations of TX -- single, multiple with commas, multiple many
lines, single bad, multiple bad, multiple mix of bad and good. verified that the
good tasks were attached to the diff and diff was attached to the good tasks.

Maniphest Tasks: T137

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, btrahan, epriestley

Differential Revision: 1165

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Dec 3 2011, 20:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPH10cc5f266066: Set user on auxiliary fields before validating them on template workflow
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH83efa6e1c5c8: make arc diff link maniphest tasks with revisions (authored by Bob Trahan <bob.trahan@gmail.com>).Dec 3 2011, 20:34