Homec4science

Match unittest results by name or file

Authored by Andrew Gallagher <agallagher@fb.com> on Jan 11 2012, 01:32.

Description

Match unittest results by name or file

Summary:
Just talked to @tuomaspelkonen, and turns out there is a case where
postponed tests results use the filepath for both the name and file
parameters. Then, after the tests have completed, the unittest
results are updated with the class name as the test name. To handle
this, this diff matches the stored unittest results name against
either the name or file component of the updated unittest info.

Not sure of great way to generally handle these situations. Perhaps,
long term, we can just use a placeholder unittest result, mark that
as passed (or delete it?) then add a new test result with the correct
name.

Test Plan: updated unittest result with new name (but file was the same).

Reviewers: epriestley, tuomaspelkonen

Reviewed By: epriestley

CC: aran, epriestley, andrewjcg

Differential Revision: https://secure.phabricator.com/D1356

Details

Committed
Andrew Gallagher <agallagher@fb.com>Jan 11 2012, 01:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH48f53ba0951a: Allow updating diff with results for new unit tests
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Gallagher <agallagher@fb.com> committed rPH840eb46d03d0: Match unittest results by name or file (authored by Andrew Gallagher <agallagher@fb.com>).Jan 11 2012, 01:51