Homec4science

Correct self-review check in Differential

Authored by epriestley <git@epriestley.com> on Oct 26 2012, 01:27.

Description

Correct self-review check in Differential

Summary: This check is currently wrong -- the actor is only coincidentally the owner (and only most of the time). It also raises at parse time, preventing any user from parsing a message with their own name in the "Reviewers" field. Instead, check against the right owner PHID and raise it only if a revision is available. See https://github.com/facebook/arcanist/issues/54 and next diff.

Test Plan: Tried to add myself as a reviewer to revisions I own via web and Conduit, got rejected. Parsed a message with myself in the "Reviewers:" field, it worked correctly.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3820

Details

Committed
epriestley <git@epriestley.com>Oct 26 2012, 01:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH731a6900bd0f: upgrade repository delete function to full-blown workflow
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH846f01e221a9: Correct self-review check in Differential (authored by epriestley <git@epriestley.com>).Oct 26 2012, 01:27