Homec4science

Differential - return a better response for validation error cases

Authored by Bob Trahan <btrahan@phacility.com> on Jan 20 2015, 22:59.

Description

Differential - return a better response for validation error cases

Summary: Fixes T6989. Basically return a nice dialogue like we do for "NoEffect" transactions. This is a little prettier than the other dialogue was. Also, stop adding TYPE_EDGE as a transaction type as we end up having it 2x, which then makes the error get validated 2x.

Test Plan: tried to add myself as a reviewer and got a nice error message.

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6989

Differential Revision: https://secure.phabricator.com/D11448

Details

Committed
Bob Trahan <btrahan@phacility.com>Jan 20 2015, 22:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH77bcbed9f98e: Implement PolicyAwareQuery for triggers
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH847ff549ceee: Differential - return a better response for validation error cases (authored by Bob Trahan <btrahan@phacility.com>).Jan 20 2015, 22:59