re-factor DifferentialChangesetParser pass 3 / N
84c27ae255dc
Actions

Authored by Bob Trahan <bob.trahan@gmail.com> on Jan 9 2013, 22:11.

Description

re-factor DifferentialChangesetParser pass 3 / N

Summary: introducing a new friend called DifferentialHunkParser. Sort of like the DifferentialChangesetParser but works with hunks only. tried to grab hunk parsing type things from across the code base and move them into this new class.

Test Plan: unit tests and played around in Differential a bit.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4351

Details

Committed

Bob Trahan <bob.trahan@gmail.com>

Jan 9 2013, 22:11

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHe928f8d869db: Have form elements default to the standard font size.

Branches

Unknown

Tags

Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH84c27ae255dc: re-factor DifferentialChangesetParser pass 3 / N (authored by Bob Trahan <bob.trahan@gmail.com>).Jan 9 2013, 22:11

Changes (8)

				Path
	M			src/__phutil_library_map__.php
	M			src/applications/differential/mail/DifferentialCommentMail.php
	M			src/applications/differential/parser/DifferentialChangesetParser.php
	A			src/applications/differential/parser/DifferentialHunkParser.php
	V			src/applications/differential/{parser/__tests__/DifferentialHunkParserTestCase.php ← storage/__tests__/DifferentialChangesetTestCase.php}
	M			src/applications/differential/storage/DifferentialChangeset.php
	M			src/applications/differential/storage/DifferentialDiff.php
	V			src/applications/differential/{storage/__tests__/DifferentialChangesetTestCase.php → parser/__tests__/DifferentialHunkParserTestCase.php}