Homec4science

Kill PhabricatorFileURI

Authored by Bob Trahan <bob.trahan@gmail.com> on Jan 10 2012, 23:48.

Description

Kill PhabricatorFileURI

Summary:
we used to need this function for security purposes, but no longer need
it. remove it so that some call sites can be optimized via smarter data
fetching, and so the whole codebase can have one less thing in it.

Test Plan:
verified the images displayed properly for each of the following

  • viewed a diff with added images.
  • viewed a user feed
  • viewed a user profile
  • viewed all image macros
  • viewed a paste and clicked through "raw link"

weakness in testing around proxy files and transformed files. not sure what
these are. changes here are very programmatic however.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, btrahan, epriestley

Maniphest Tasks: T672

Differential Revision: https://secure.phabricator.com/D1354

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jan 11 2012, 00:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb9cac3bcd13b: Improve phabot handling of private messages
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH84ea5c53e4e4: Kill PhabricatorFileURI (authored by Bob Trahan <bob.trahan@gmail.com>).Jan 11 2012, 00:21