Homec4science

Factor out task execution and formalize permanent failures

Authored by epriestley <git@epriestley.com> on Nov 1 2012, 19:30.

Description

Factor out task execution and formalize permanent failures

Summary:

  • Clean up a TODO about permanent failures.
  • Clean up a TODO about failing tasks after too many retries.
  • Clean up a TODO about testing for bad leases.
  • Make the lease/retry implementation more flexible and natural.
  • Make completely bogus tasks fail permanently.
  • Make PhabricatorMetaMTAWorker use new getWaitBeforeRetry() (as intended), not hackily implement logic in getRequiredLeaseTime().
  • Document worker hooks for failures and retries.
  • Provide coverage on everything.

Test Plan: Ran unit tests. Ran bin/phd debug taskmaster.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2015

Differential Revision: https://secure.phabricator.com/D3859

Details

Committed
epriestley <git@epriestley.com>Nov 1 2012, 19:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH88fad90c1c0a: Move task leasing to a dedicated query
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH84ee4cd9f62f: Factor out task execution and formalize permanent failures (authored by epriestley <git@epriestley.com>).Nov 1 2012, 19:30