Homec4science

Minor, fix an issue with PhabricatorMenuView and default null keys.

Authored by epriestley <git@epriestley.com> on Feb 6 2013, 20:41.

Description

Minor, fix an issue with PhabricatorMenuView and default null keys.

This is kind of gross, but breaking some menus right now which end up with double-'' keys. The current meaning of setKey(null) is different from not calling it (it means setKey('')).

This should be fixed more reasonably but there's a lot of legacy cruft in PhabricatorSideNavFilterView.

Auditors: btrahan

Details

Committed
epriestley <git@epriestley.com>Feb 6 2013, 20:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPH57c001f52244: Select portions from mock
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH84efcb86698a: Minor, fix an issue with PhabricatorMenuView and default null keys. (authored by epriestley <git@epriestley.com>).Feb 6 2013, 20:42