Homec4science

Move ported inlines which appear on nonvisible lines backward so they show up

Authored by epriestley <git@epriestley.com> on Apr 21 2015, 15:59.

Description

Move ported inlines which appear on nonvisible lines backward so they show up

Summary:
Ref T7447. Ref T7870. See T7870 for a detailed description of this issue.

NOTE: Replying to these inlines from the UI still does the wrong thing, because we use the database line number, not the UI line number.

Test Plan:
Before:

{F377732}

After:

{F377733}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7447, T7870

Differential Revision: https://secure.phabricator.com/D12491

Details

Committed
epriestley <git@epriestley.com>Apr 21 2015, 20:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfe774e68e255: Distinguish between ported-forward and ported-backward comments
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH84f62bdf9a79: Move ported inlines which appear on nonvisible lines backward so they show up (authored by epriestley <git@epriestley.com>).Apr 21 2015, 20:06