Homec4science

Allow config get to work when db is not functional

Authored by Scott Kroll <skroll@gmail.com> on Nov 14 2014, 18:12.

Description

Allow config get to work when db is not functional

Summary: Fixes T6554.

Test Plan:
Run bin/config get mysql.host when no db is functional. Should not get an exception, but should see:

{
  "config" : [
    {
      "key"       : "mysql.host",
      "source"    : "local",
      "value"     : null,
      "status"    : "unset",
      "errorInfo" : null
    },
    {
      "key"       : "mysql.host",
      "source"    : "database",
      "value"     : null,
      "status"    : "error",
      "errorInfo" : "Database source is not configured properly"
    }
  ]
}

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Maniphest Tasks: T6554

Differential Revision: https://secure.phabricator.com/D10851

Details

Committed
epriestley <git@epriestley.com>Nov 14 2014, 18:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb85283105ece: Phriction - restore diff link
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH84f741f40851: Allow config get to work when db is not functional (authored by Scott Kroll <skroll@gmail.com>).Nov 14 2014, 18:12