Homec4science

Don't try to rebuild a repository graph cache bucket more than once per request

Authored by epriestley <git@epriestley.com> on May 11 2014, 17:46.

Description

Don't try to rebuild a repository graph cache bucket more than once per request

Summary: Ref T2683. This is a small optimization, but it has low complexity: don't rebuild a bucket more than once in the same request, since it will almost always be the same. Bucket rebuilds are pretty cheap, but this saves a few queries.

Test Plan:

  • After discovering (but before parsing) a commit, viewed its browse view. Verified that this patch causes us to perform only one bucket rebuild, and therefore reduces the number of queries we issue.
  • Parsed the commit and viewed the browse view again, got successful rebuild and then fills from cache.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2683

Differential Revision: https://secure.phabricator.com/D9055

Details

Committed
epriestley <git@epriestley.com>May 12 2014, 20:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcfa265f02091: Make sure READMEs can hit the markup cache in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH84fc8f0baf9f: Don't try to rebuild a repository graph cache bucket more than once per request (authored by epriestley <git@epriestley.com>).May 12 2014, 20:47