Homec4science

Render dropdown metadata earlier

Authored by epriestley <git@epriestley.com> on Jun 20 2016, 20:49.

Description

Render dropdown metadata earlier

Summary:
Ref T11179. One issue I'm getting with trying to turn actions into dropdowns is that we currently render this menu very late, which can cause us to try to add more metadata after we start resolving metadata. This won't work right now (and making it work seems unreasonably complicated), so stop doing it and fatal if something tries.

(This might make some things fatal but should be safe -- anything that fatals should have been broken already.)

Test Plan:
Browsed around looking for fatals, didn't see any.

(This primarily avoids a broken state / fatal in a future diff.)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11179

Differential Revision: https://secure.phabricator.com/D16151

Details

Committed
epriestley <git@epriestley.com>Jun 21 2016, 00:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPH967945e4b4e9: Add ability to link back to parent site in external phame blogs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH851aba80ce06: Render dropdown metadata earlier (authored by epriestley <git@epriestley.com>).Jun 21 2016, 00:35