Homec4science

Implement "Edit Members" and "Join/Leave" with real ApplicationTransactions

Authored by epriestley <git@epriestley.com> on Feb 10 2014, 23:30.

Description

Implement "Edit Members" and "Join/Leave" with real ApplicationTransactions

Summary:
Ref T4379. Projects has been partially converted to ApplicationTransactions, but the rough state of the world is that all the storage is modern, but most of the stuff on top isn't yet. Particularly, there's a PhabricatorProjectEditor which is not a subclass of PhabricatorApplicationTransactionEditor, but which fakes its way through writing reasonable data into modern storage.

This introduces a real transaction editor, PhabricatorProjectTransactionEditor, with the eventual goal of moving all of the old functionality into it and deleting the old class. This diff only moves the membership transaction into new code (it doesn't even move all of it -- when we create a project, we add the author as a member, and that can't move quite yet since there are other transactions at the same time).

Test Plan:

  • Created a new project.
  • Edited members.
  • Joined / left project.
  • This already has a pile of unit test coverage.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4379

Differential Revision: https://secure.phabricator.com/D8167

Details

Committed
epriestley <git@epriestley.com>Feb 10 2014, 23:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2141a28f1b01: Improve detection of no-op edge edits in ApplicationTransactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8544d0d00f08: Implement "Edit Members" and "Join/Leave" with real ApplicationTransactions (authored by epriestley <git@epriestley.com>).Feb 10 2014, 23:30