Homec4science

Policy - lock down loadCommit() from DiffusionRequest objects

Authored by Bob Trahan <btrahan@phacility.com> on Feb 1 2015, 18:33.

Description

Policy - lock down loadCommit() from DiffusionRequest objects

Summary: Ref T7094. The class DiffusionRequest has other public methods which use getUser() in an unguarded way. Code inspection of the call sites for loadCommit() also leads me to believe the $user is properly set.

Test Plan: clicked around diffusion a bunch and everything seemed to work okay. (happy to test any particular esoteric endpoints that come to mind)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7094

Differential Revision: https://secure.phabricator.com/D11585

Details

Committed
Bob Trahan <btrahan@phacility.com>Feb 1 2015, 18:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH93e6a9b3caad: Allow subscriptions to cost amounts other than one dollar and twenty three cents
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH8573d5b0c1a3: Policy - lock down loadCommit() from DiffusionRequest objects (authored by Bob Trahan <btrahan@phacility.com>).Feb 1 2015, 18:33