Homec4science

Write edges for commit reverts

Authored by Joshua Spence <josh@joshuaspence.com> on Jan 4 2015, 20:52.

Description

Write edges for commit reverts

Summary:
Ref T1751. When a commit reverts another commit:

  • Add an edge linking them;
  • Show the edge in Diffusion.

Next steps are:

  • If the reverted commit is associated with a Differential revision, leave a comment;
  • Also leave a comment on the commit (no API yet);
  • Also trigger an audit by the original commit's author.

Test Plan: Used scripts/repository/reparse.php --message ... to parse commits with revert language. Verified they appear correctly in Diffusion, and update Differential.

Reviewers: btrahan, epriestley

Reviewed By: btrahan, epriestley

Subscribers: Korvin, epriestley, cburroughs, joshuaspence, sascha-egerer, aran

Maniphest Tasks: T4896, T1751

Differential Revision: https://secure.phabricator.com/D5846

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jan 4 2015, 21:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfe618772fd79: Show unit test namespaces
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH85a363674743: Write edges for commit reverts (authored by Joshua Spence <josh@joshuaspence.com>).Jan 4 2015, 21:09