Homec4science

Hide direct accesses to Audit inline comment table behind API

Authored by epriestley <git@epriestley.com> on Jul 25 2014, 02:59.

Description

Hide direct accesses to Audit inline comment table behind API

Summary: Ref T4896. Move all direct accesses to the inline comment table behind a small amount of API to make it easier to migrate the table.

Test Plan:

  • Grepped for PhabricatorAuditInlineComment.
  • Grepped for audit_inlinecomment.
  • Created a draft comment.
  • Previewed a draft comment.
  • Reloaded page, still saw draft.
  • Viewed standalone, still saw draft.
  • Made comment, inline published.
  • Added a draft, saw both.
  • Edited inline comment.
  • Reindexed commit.
  • Searched for unique word in published comment, found commit.
  • Searched for unique word in draft comment, no results.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T4896

Differential Revision: https://secure.phabricator.com/D10016

Details

Committed
epriestley <git@epriestley.com>Jul 25 2014, 02:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH023dee0d3b6d: Rename Conduit classes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8605a1808d01: Hide direct accesses to Audit inline comment table behind API (authored by epriestley <git@epriestley.com>).Jul 25 2014, 02:59