Homec4science

Fix reticle for diff-of-diffs

Authored by epriestley <git@epriestley.com> on Apr 7 2012, 19:39.

Description

Fix reticle for diff-of-diffs

Summary:
The older logic was incorrect:

  • It chose change.left for data.on_right being true.
  • 'O' and 'N' mean 'old' and 'new', not 'left' and 'right'. In diff-of-diffs, both sides are 'N'.

So, select the changeset ID correctly (pick the right side one for on_right), and select the new file prefix correctly (N for new, O for old).

Test Plan: Waved my mouse over some inline comments in a diff-of-diffs, got reasonable-looking reticles.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1076

Differential Revision: https://secure.phabricator.com/D2138

Details

Committed
epriestley <git@epriestley.com>Apr 7 2012, 19:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7507981f2264: Don't fatal with inaccessible database
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH869f24bf333a: Fix reticle for diff-of-diffs (authored by epriestley <git@epriestley.com>).Apr 7 2012, 19:39