Homec4science

Show icons and disabled/archived/closed results in typahead dynamic list

Authored by epriestley <git@epriestley.com> on Feb 14 2014, 19:24.

Description

Show icons and disabled/archived/closed results in typahead dynamic list

Summary:
Ref T4420. This is mostly a design change, but addresses two functional issues:

  1. Many sources exclude disabled accounts, system agents, archived projects, etc. It is rare to select these, but excluding them completely is too severe, and we've made more than a handful of changes over time to replace a "users" endpoint with an "accounts" endpoint (to include disabled users) or similar. Instead, always show these results, but sort them last and use a special style to clearly mark them as closed, disabled, or otherwise unusual.
    • As a practical consequence, all the similar endpoints can now be merged, so "accounts" and "users" return the exact same result sets.
  2. Increasingly, sources can return multiple object types in a single list. For example, "CC" can have a user or mailing list, and soon a project or repository. However, the result list is fairly homogenous across types and it isn't easy to quickly pick out projects vs users. To help with this, add icons showing the result type.

Test Plan:
{F113079}

(The main search results get touched here too, I verified they didn't blow up.)

Reviewers: chad, btrahan

Reviewed By: chad

CC: chad, aran, mbishopim3

Maniphest Tasks: T4420

Differential Revision: https://secure.phabricator.com/D8231

Details

Committed
epriestley <git@epriestley.com>Feb 14 2014, 19:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3c19f363bf47: Provide result type information in tokenizers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH87012d60f1d0: Show icons and disabled/archived/closed results in typahead dynamic list (authored by epriestley <git@epriestley.com>).Feb 14 2014, 19:24